8000 Minor fixes to documentation for merge by drj11 · Pull Request #3588 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Minor fixes to documentation for merge #3588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2024
Merged

Minor fixes to documentation for merge #3588

merged 1 commit into from
Jul 18, 2024

Conversation

drj11
Copy link
Contributor
@drj11 drj11 commented Jul 18, 2024

Mostly fixing the explanation of how glyphs get renamed (they get .n added, not #n), but couldn't resist a couple of other minor fixups too.

@drj11
Copy link
Contributor Author
drj11 commented Jul 18, 2024

By the way, i'm not sure that the sentence "If duplicate glyph disambiguation takes place as described above then the fonts must have a GSUB table." is true (any more?). For example the following works and the fontfile does not have a GSUB table.

pyftmerge CraftyGirls-Regular.ttf CraftyGirls-Regular.ttf

@behdad
Copy link
Member
behdad commented Jul 18, 2024

By the way, i'm not sure that the sentence "If duplicate glyph disambiguation takes place as described above then the fonts must have a GSUB table." is true (any more?). For example the following works and the fontfile does not have a GSUB table.

We do the disambiguation only if the two glyphs have different shapes. I'll try to update the documentation.

@behdad behdad merged commit 4214a66 into fonttools:main Jul 18, 2024
11 checks passed
@behdad
Copy link
Member
behdad commented Jul 18, 2024

By the way, i'm not sure that the sentence "If duplicate glyph disambiguation takes place as described above then the fonts must have a GSUB table." is true (any more?). For example the following works and the fontfile does not have a GSUB table.

We do the disambiguation only if the two glyphs have different shapes. I'll try to update the documentation.

Looks like the docu already mentions that.

@drj11
Copy link
Contributor Author
drj11 commented Jul 18, 2024

Oh yes, i did actually read that. It doesn't work, or there is something more subtle going on.

The merged TTF has double the number of glyphs (TTF is from https://github.com/google/fonts/tree/main/apache/craftygirls by the way)

; otfinfo --glyphs CraftyGirls-Regular.ttf | wc
     230     230    1604
; otfinfo --glyphs merged.ttf | wc
     460     460    3668

@drj11 drj11 deleted the drj11/merge-doc branch July 18, 2024 19:24
@behdad
Copy link
Member
behdad commented Jul 18, 2024

The merge tool is very incomplete and unmaintained unfortunately...

I suspect we add the duplicate glyph, just never use it...

@drj11
Copy link
Contributor Author
drj11 commented Jul 18, 2024

Fair enough. i was poking around because i was thinking of writing a merging tool. :)

@behdad
Copy link
Member
behdad commented Jul 18, 2024

All yours to take. As we say: "you touch it you own it". :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drj11 @behdad
0