8000 Revert "[svgPen] Write two digits after decimal by default" by madig · Pull Request #3543 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "[svgPen] Write two digits after decimal by default" #3543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2024
Merged

Revert "[svgPen] Write two digits after decimal by default" #3543

merged 2 commits into from
May 30, 2024

Conversation

madig
Copy link
Collaborator
@madig madig commented May 30, 2024

This reverts commit 42d6b6b.

As discussed with @anthrotype, this changed default behavior.

@anthrotype anthrotype requested a review from behdad May 30, 2024 10:58
@behdad
Copy link
Member
behdad commented May 30, 2024

Fine to revert. I'll open an issue for it. I think adding a new argument to do compact writing is preferred for me than making all callers provide their custom ntos. My use-case for this was when we pass --variations to svgPathPen cmdline, everything suddenly becomes float, and written to many digits.

@behdad behdad merged commit 313328b into main May 30, 2024
11 checks passed
@behdad behdad deleted the revert-svgpathpen-rounding branch May 30, 2024 17:31
@behdad behdad mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behdad behdad Awaiting requested review from behdad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madig @behdad
0