[VARC] Update to reinterpretation of RESET_UNSPECIFIED_AXES #3541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I now remember better what "rawLocation" is about: it should perhaps be called "sparseLocation".
It is needed to preserve the information which axes are specified for addVarComponent(). Without the rawLocation mechanism, it is not possible to extract variable components correctly, you can only render them.
I will experiment a bit, but I think instead of this PR, all we need to do is to change the reset of rawLocation to self.originalLocation.copy(). The self.rawLocation = {} in the else is (I think) a crucial thing to keep. I'll get back about this later.
|
Okay let's continue in #3549 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements:
harfbuzz/boring-expansion-spec@3f5cdc4