[instancer] Fix output filename decision-making #3548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All limits are tuples now when not None. The old logic was broken and for the following command: $ fonttools varLib.instancer AdobeVFPrototype.otf CNTR=50:80 wght=900 it was saving the output with the name suffix `-instance`, whereas it's clearly a partial instantiation. This fixes that.
|
Sorry I haven't added tests for this. Would appreciate if someone else does. |
|
LGTM. Tested locally with wght="drop", wght=900 or wght=900:900 and all work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All limits are tuples now when not None. The old logic was broken and for the following command:
$ fonttools varLib.instancer AdobeVFPrototype.otf CNTR=50:80 wght=900
it was saving the output with the name suffix
-instance, whereas it's clearly a partial instantiation. This fixes that.