10000 [colrv1] use math.isclose with relative tolerance to check radial circles' inside-ness by anthrotype · Pull Request #2521 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[colrv1] use math.isclose with relative tolerance to check radial circles' inside-ness #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2022
Merged

[colrv1] use math.isclose with relative tolerance to check radial circles' inside-ness #2521

merged 1 commit into from
Feb 1, 2022

Conversation

anthrotype
Copy link
Member

Fixes rounding of radial gradient geometry in 'SING OF THE HORNS' (medium-light skin tone) noto emoji 🤘🏼

noto-emoji CORLv1 font before this patch (notice the darker knuckle):

Screenshot 2022-01-31 at 18 08 23

And after this patch (all look good):

Screenshot 2022-01-31 at 18 07 58

This is basically the same bug as googlefonts/picosvg#158 which affected the 🦟 mosquito emoji. It turns out the tolerance we are using to consider whether start circle is inside the end circle was too strict/tight. Relaxing a bit, and making it relative tolerance (as in math.isclose as opposed to absolute difference) makes both the 🦟 and the 🤘🏼 happy.

@anthrotype
[colorLib.geometry] use math.isclose with relative tolerance to check…
5558ccd 
… circle inside-ness

Fixes rounding of radial gradient in 'SING OF THE HORNS' (medium-light skin tone) noto emoji 🤘🏼
@anthrotype anthrotype merged commit f3b4c5b into main Feb 1, 2022
@anthrotype anthrotype deleted the fix-round-radial-gradient-circle branch February 1, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsheeter rsheeter rsheeter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthrotype @rsheeter
0