[colrv1] ensure base glyphs with equal layers share the same PaintColrLayers #2513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PaintColrLayers this test currently fails; currently the second, third, etc. base glyphs with the same layers gets a unique PaintColrLayers with NumLayers:1 that in turn contains the shared PaintColrLayers. They should instead all share the same PaintColrLayers. Fix in the next commit
We already filter len(layers)==1 out upfront, but these can sneak in after the layer reuse code when input contains two base glyphs that refer to the same list of layers. This ensure that duplicate base glyphs get the same PaintColrLayers, rather than a wrapper PaintColrLayers of length=1 pointing to the underlying shared PaintColrLayer...
|
the failing test log for reference: |
anthrotype
added a commit
to googlefonts/nanoemoji
that referenced
this pull request
Jan 25, 2022
Includes fonttools/fonttools#2513 which ensures base glyphs with equal list of layers share the same PaintColrLayers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a colrv1 table and the input dictionary contains multiple base glyphs that map to the same layers (equal in content, not identity), we need to make sure the same PaintColrLayers is used for all of them.
Currently what happens is, the subsequent glyphs with same layers content get a new unique PaintColrLayers with only one child, i.e. the shared PaintColrLayers (see failing test).
Fix coming in a follow-up commit.
(Note the first commit eded208 is minor, unrelated change)