freetypePen: fit to content when rotated/skewed #2517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pen is designed to determine the bitmap size when omitted, which helps users to see an image somehow even when they have no idea how the arguments should be passed. And I realised that I didn't give enough thought to rotate/skew transforms in former PRs. This commit fixes the calculation of the bbox after transformation. Also tries to clear up how the autosizing options work in the docstring. Some minor fixes will follow.
anthrotype
reviewed
Jan 31, 2022
anthrotype
reviewed
Jan 31, 2022
anthrotype
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that I didn't give enough thought to the effect of rotate/skew transforms in the former PR (#2494). This PR will fix and clarify the behaviour when
widthorheightis omitted, which is the use case I failed to cover. Also contains some minor fixes.