FreeTypePen: fix missing RTD entry #2500
Conversation
Importing freetype at import time breaks the Read the Docs build. Solves the issue by raising an error in __init__ as fontTools.ttLib.woff2 does, while avoiding adding an extra line to Doc/docs-requirements.txt.
|
Will the inline documentation get built despite the import error? If not, we should just add freetype-py to the docs requirements |
#2494 emits an empty page while the check shows green. I thought keeping |
This reverts commit 24d356d.
|
thanks. It's preferable if the docs requirements include all the optional deps so all the inline docs gets built.
Hm, I guess that mean we get no RTD autodocs for woff2 module, if so we should fix that. |
|
Thank you for the merge. I don't know much about the rtd/sphinx pipeline, but the woff2 module seems to get the docs successfully without seeing |
#2494 fails to generate the corresponding RTD entry due to the lack of the dependency:
https://readthedocs.org/api/v2/build/15748934.txt
This PR solves the issue by raising ImportError in
__init__, rather than by adding a line toDoc/docs-requirements.txt.