8000 Merge tamil grantha by behdad · Pull Request #2476 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Merge tamil grantha #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2021
Merged

Merge tamil grantha #2476

merged 2 commits into from
Dec 16, 2021

Conversation

behdad
Copy link
Member
@behdad behdad commented Dec 15, 2021

Fixes #2475

@behdad behdad requested a review from anthrotype December 15, 2021 23:56
@behdad behdad mentioned this pull request Dec 15, 2021
Merged
@satbyy satbyy mentioned this pull request Dec 16, 2021
Closed
@anthrotype
Copy link
Member

Thanks Behdad! One of expected test .ttx file needs to be updated for the tests to pass. The lint job failing is unrelated, you can merge/rebase master to make it green again.

@behdad
[merger] Fix duplicate-glyph-resolution GSUB-lookup generation code
e547db5 
Part of fixing #2475

Old code was mistakenly only adding the synthetic-generated feature
to the first language-system. In the case of merging Noto Grantha
and Noto Tamil fonts, Noto Tamil had two script systems: 'taml' and
'tml2', and we were adding the synthetic 'locl' feature only to the
DefaultLangSys of the 'taml' script, not the 'tml2' script. That was
the main bug.

A second issue was that the lookup was being added twice to the same
(synthetic) feature. Check before adding lookup, to avoid that.
@behdad
[merge] Remove _glyphsAreSame() check
d8758c5 
This was removing semantically-significant difference amongst glyphs
such as two identical glyphs one in Noto Sans Tamil one in Noto Sans
Grantha as in the following issue:

Part of fixing #2475
@behdad behdad force-pushed the merge-tamil-grantha branch from b8ad3f7 to d8758c5 Compare December 16, 2021 14:56
@behdad behdad merged commit b63f641 into main Dec 16, 2021
@khaledhosny khaledhosny deleted the merge-tamil-grantha branch December 18, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype Awaiting requested review from anthrotype

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pyftmerge breaks fonts that support the same character
2 participants
@behdad @anthrotype
0