[subset/COLR] fix error when subsetting mixed COLR v0/v1 leaves no v0 records #2308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently throws a KeyError: ('uniE004', 'BaseGlyphRecordArray')
…in populateCOLRv0 Same when LayerV1List is empty. All these fields are optional in v1
…etting COLRv1 table Thanks Qunxin for reporting the bug!
anthrotype
added a commit
to googlefonts/nanoemoji
that referenced
this pull request
May 17, 2021
Latest fontTools.colorLig sets LayerV1List attribute to None when empty, it's optional in CORLv1 (fonttools/fonttools#2308). Full changelogs since 4.22 https://github.com/fonttools/fonttools/releases/tag/4.22.1 https://github.com/fonttools/fonttools/releases/tag/4.23.0 https://github.com/fonttools/fonttools/releases/tag/4.23.1
rsheeter
pushed a commit
to googlefonts/nanoemoji
that referenced
this pull request
Jul 31, 2021
Latest fontTools.colorLig sets LayerV1List attribute to None when empty, it's optional in CORLv1 (fonttools/fonttools#2308). Full changelogs since 4.22 https://github.com/fonttools/fonttools/releases/tag/4.22.1 https://github.com/fonttools/fonttools/releases/tag/4.23.0 https://github.com/fonttools/fonttools/releases/tag/4.23.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @qxliu76 for reporting this bug!
I first add a failing test to repro the issue, then follow up with the fix