8000 make function posix(path) in designspaceLib work with Windows UNC path by Eigi · Pull Request #2306 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

make function posix(path) in designspaceLib work with Windows UNC path #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2021
Merged

Conversation

Eigi
Copy link
Contributor
@Eigi Eigi commented May 13, 2021

fix for #2299

@anthrotype
Copy link
Member

can you elaborate a bit on how you use UNC paths in designspace files?
According to the spec, the filename attribute should contain only relative paths, and as far as I understand these UNC paths are by definition absolute paths.

@Eigi
Copy link
Contributor Author
Eigi commented May 13, 2021

Yes, the filename attribute is relative, but the path attribute of the designSpaceDocument itself is absolut. And the path attribute of sources and instances is calculated as absolute paths form the respective filename and the path of the designSpaceDocument. The error occurs if the designSpaceDocument is loaded from a server with an UNC path. As a result the sources can't be loaded even if they are in the same folder as the designSpaceDocument. This is the standard situation in my production environment.

8000

@anthrotype
Copy link
Member

i see. But are you sure that inserting two leading forward slashes will still make it work as a UNC path? Don't the latter always require two backslashes? /cc @madig

@Eigi
Copy link
Contributor Author
Eigi commented May 13, 2021

two leading forward slashes work. and we have one forward slash in the mount part of the UNC path anyway, between server and share. //server/share/folder/filename.

@anthrotype
Copy link
Member

ok, let's merge it then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0