8000 Instancer: update name table (take 2) by anthrotype · Pull Request #2189 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Instancer: update name table (take 2) #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Feb 26, 2021
Merged

Instancer: update name table (take 2) #2189

merged 28 commits into from
Feb 26, 2021

Conversation

anthrotype
Copy link
Member

I moved @m4rc1e branch to upstream repo (named instancer-name) and moved some files around.

This supersedes #2078

@anthrotype anthrotype mentioned this pull request Feb 15, 2021
Closed
Base automatically changed from master to main February 17, 2021 11:56
@moyogo moyogo mentioned this pull request Feb 24, 2021
Merged
@anthrotype
Copy link
Member Author
anthrotype commented Feb 25, 2021 •
edited
Loading

@m4rc1e do you think this is ready to merge?

@m4rc1e
Copy link
Contributor
m4rc1e commented Feb 26, 2021 •
edited
Loading

Just finished testing on Roboto, Cabin and Open Sans. It's behaving as expected but the following could be improved:

  • Drop name records which have a nameID 25 if we're instantiating a static font
  • What about updating the filenames?

I'll implement dropping nameID 25 now. For updating the filename, we can tackle this when we set the bits correctly, or if the heuristic is too complex, leave it be.

@m4rc1e m4rc1e force-pushed the instancer-name branch 2 times, most recently from c78a035 to 4f84830 Compare February 26, 2021 10:19
m4rc1e added 21 commits February 26, 2021 10:19
@m4rc1e
WIP instancer: update static font nametable
b956075
@m4rc1e
wip instancer: support format 4 axisvalues
b502471
@m4rc1e
Fix typos
4cd0fb8
@m4rc1e
instancer: add test for partial instance name
78f6c2a
@m4rc1e
Refactor axisValuesFromAxisLimits
2fd9340
@m4rc1e
instancer: only updateNames if axisValue with specified coord exists
f89c01d
@m4rc1e
instancer: include attribute axisValues
b4b1ce3
@m4rc1e
instancer: use bit mask for axisValue flags
0b639c2
@m4rc1e
instancer: sort axisValues so format 4 are dominant for constructing …
69c8667 
…names
@m4rc1e
instancer: Add axisDefaults to axisLimits
ce1d8a9
@m4rc1e
wip instancer: update uniqueID
b328475
@m4rc1e
instancer: refactor updateNameTable
9a72311
@m4rc1e
instancer: reuse existing instantiateSTAT func
0bcbbfd
@m4rc1e
cleanup _updateUniqueIdNameRecord
11f0ade
@m4rc1e
instancer: updateNameTableStyleRecords use strings as input instead o…
bef1d08 
…f axis values
@m4rc1e
instancer: implement Cosimo feedback
29e4ff9
@m4rc1e
Only create typographic subfamily name if there are nonRibbi tokens
5eac886
@m4rc1e
Tidy up variable name and run through black
de38c9c
@m4rc1e
Implement Adobe ps naming for instantiated instances
daf6427
@m4rc1e
Implement Cosimo feedback
336e782
@m4rc1e
Parametrize updateNameTable tests
0280eb3
anthrotype and others added 7 commits February 26, 2021 10:31
@anthrotype
make instancer into a package dir and move all names-related funcs to…
2be13d5 
… submodule

move instancer tests to Tests/varLib/instancer directory

create instancer/__main__.py to make package executable
@m4rc1e @anthrotype
Implement Cosimo feedback from previous pr
fcc0282
@anthrotype
make docstring shorter; fix _isRibbi
fcfcb78 
return True only if a corresponding english record is found and matches R/I/B/BI, else return False.
We don't really care if there are any other unrelated english records, we care about this specific one, whether it's RIBBI or not

minor
@anthrotype
fix sub-string check in update uniqueID
0c92d33
@anthrotype
fall back to 'Regular' when no subFamilyName
d1a8e1e 
assert we have some 'string' instead of silently continuing
@m4rc1e @anthrotype
Add test for Regular fallback
a7913ef
@m4rc1e @anthrotype
Drop nameID 25 if instantiating a static font
52fec53
@anthrotype
Copy link
Member Author

LGTM (it seems Github doesn't let PR authors approve their own PRs 😅..)

@m4rc1e m4rc1e merged commit 52b742f into main Feb 26, 2021
@khaledhosny khaledhosny deleted the instancer-name branch February 26, 2021 17:10
@anthrotype anthrotype mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4rc1e m4rc1e m4rc1e left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthrotype @m4rc1e
0