8000 Update to latest COLR v1 (PaintRotate, PaintSkew) by rsheeter · Pull Request #2118 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update to latest COLR v1 (PaintRotate, PaintSkew) #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2020
Merged

Update to latest COLR v1 (PaintRotate, PaintSkew) #2118

merged 2 commits into from
Dec 4, 2020

Conversation

rsheeter
Copy link
Collaborator
@rsheeter rsheeter commented Dec 3, 2020 •
edited
Loading

Update for format changes in googlefonts/colr-gradients-spec#113

@rsheeter rsheeter requested a review from anthrotype December 3, 2020 06:59
anthrotype
anthrotype approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member
@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending update of binary data test

Tests/ttLib/tables/C_O_L_R_test.py
@@ -37,6 +40,15 @@ def dump(table, ttFont=None):
print("\n".join(getXML(table.toXML, ttFont)))


def diff_binary_fragments(font_bytes, expected_fragments):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this 👍

@rsheeter rsheeter changed the title DRAFT Update to latest COLR v1 (PaintRotate, PaintSkew) Update to latest COLR v1 (PaintRotate, PaintSkew) Dec 3, 2020
@rsheeter rsheeter marked this pull request as ready for review December 3, 2020 20:45
@anthrotype anthrotype merged commit 6e9bb9b into master Dec 4, 2020
@anthrotype anthrotype deleted the colr_angles branch December 4, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsheeter @anthrotype
0