8000 Added QuartzPen by verbosus · Pull Request #2107 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added QuartzPen #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Added QuartzPen #2107

merged 1 commit into from
Nov 20, 2020

Conversation

verbosus
Copy link
Contributor

FontTools supports drawing on macOS via the CocoaPen, which transforms a path into an NSBezierPath. However, for lower-level drawing on macOS, animation with CoreAnimation, and other use-cases, it’s useful to have outlines represented as CGPath instead of NSBezierPath. RoboFab used to have a QuartzPen but it’s no longer functional under Python 3. This PR adds a QuartzPen back to FontTools, together with some unit tests that only run when PyObjC is installed.

Copy link
Member
@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie Antonio! LGTM

@verbosus
Copy link
Contributor Author

Wow, Travis really does take forever. A few minor improvements:

  • I added tests for CocoaPen too, since it didn’t have any;
  • I removed an unused import in the QuartzPen tests;

I think it would be nice if the Travis osx build environment installed pyobjc by default, so the tests actually run there, but I don’t know how to do that.

@anthrotype
Copy link
Member
anthrotype commented Nov 19, 2020

it would be nice if the Travis osx build environment installed pyobjc by default

sure, but maybe better to do that after we have completed the migration to Github Actions (#2100)

@anthrotype
Copy link
Member

can you please try to rebase off master? I just merged GH Actions PR

@verbosus
Copy link
Contributor Author

Done, I’ve rebased the PR off of ae07ce6 and squashed all my commits in one.

@anthrotype anthrotype merged commit 47a272a into fonttools:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0