8000 Add HashPointPen from psautohint by jenskutilek · Pull Request #2005 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add HashPointPen from psautohint #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Oct 22, 2020
Merged

Add HashPointPen from psautohint #2005

merged 25 commits into from
Oct 22, 2020

Conversation

jenskutilek
Copy link
Collaborator

Adapted from https://github.com/adobe-type-tools/psautohint/blob/08b346865710ed3c172f1eb581d6ef243b203f99/python/psautohint/ufoFont.py#L800-L838

The pen generates a hash from a glyph's outlines and components and can be used to check if a glyph has changed.

justvanrossum
justvanrossum reviewed Jun 26, 2020
View reviewed changes
Copy link
Collaborator
@justvanrossum justvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should at least have doctests, if not a proper test file.

anthrotype
anthrotype reviewed Jul 2, 2020
View reviewed changes
Copy link
Member
@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests would be good

@jenskutilek
Copy link
Collaborator Author

I added some tests and fixes. I think that's it.

anthrotype
anthrotype reviewed Jul 23, 2020
View reviewed changes
anthrotype
anthrotype reviewed Jul 23, 2020
View reviewed changes
anthrotype
anthrotype reviewed Jul 23, 2020
View reviewed changes
anthrotype
anthrotype reviewed Jul 23, 2020
View reviewed changes
anthrotype
anthrotype reviewed Jul 23, 2020
View reviewed changes
anthrotype
anthrotype reviewed Jul 28, 2020
View reviewed changes
Copy link
Member
@anthrotype anthrotype left a comment
8000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add a test containing nested composite glyphs? After that I think it's ready to be merged

anthrotype
anthrotype reviewed Jul 29, 2020
View reviewed changes
@anthrotype
Copy link
Member
anthrotype 8000 commented Jul 29, 2020

I suggest you add some examples of how to use the pen in the class docstring

@jenskutilek
Copy link
Collaborator Author

I will resume working on this beginning of September.

@jenskutilek jenskutilek mentioned this pull request Aug 12, 2020
Closed
@jenskutilek
Copy link
Collaborator Author

I think this is ready to be merged if no further issues arise. WDYT, @anthrotype?

This was referenced Oct 21, 2020
Merged
Merged
anthrotype
anthrotype approved these changes Oct 21, 2020
View reviewed changes
@jenskutilek jenskutilek merged commit b9c2689 into master Oct 22, 2020
@jenskutilek jenskutilek deleted the hashpointpen branch October 23, 2020 11:09
jenskutilek added a commit to jenskutilek/extractor that referenced this pull request Nov 16, 2020
@jenskutilek
Update FontTools dependency to 4.17.0 (needs fonttools/fonttools#2005)
1895d8a
@jenskutilek jenskutilek mentioned this pull request Nov 18, 2020
Merged
@jenskutilek jenskutilek mentioned this pull request Jan 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justvanrossum justvanrossum justvanrossum left review comments

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenskutilek @anthrotype @justvanrossum
0