8000 Fix: ttLib _h_e_a_d FontBBox rounding by PeterDekkers · Pull Request #1605 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: ttLib _h_e_a_d FontBBox rounding #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2019
Merged

Fix: ttLib _h_e_a_d FontBBox rounding #1605

merged 3 commits into from
May 9, 2019

Conversation

PeterDekkers
Copy link
Contributor

Ensures that CFF FontBBox float values are rounded before being read into _h_e_a_d table.

Note: I had a look in regards to adding a unit test for this fix, but couldn't find any existing tests for class table__h_e_a_d. Do let me know if I missed an obvious place to add a test.

Resolves #1604

@anthrotype
Copy link
Member

Thanks!

@anthrotype anthrotype merged commit 85c3f85 into fonttools:master May 9, 2019
@PeterDekkers
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justvanrossum justvanrossum justvanrossum approved these changes

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Float yMin value: required argument is not an integer
3 participants
@PeterDekkers @anthrotype @justvanrossum
0