8000 Fix bug in subsetting T2 CharStrings from CFF font, issue 1590 by readroberts · Pull Request #1594 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix bug in subsetting T2 CharStrings from CFF font, issue 1590 #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2019
Merged

Fix bug in subsetting T2 CharStrings from CFF font, issue 1590 #1594

merged 2 commits into from
May 2, 2019

Conversation

readroberts
Copy link
Collaborator

Fixes issue '[subset] AssertionError when using --desubroutinize #1590'

@readroberts
Fix bug in subsetting T2 CharStrings from CFF font. The logic seeks t…
dbcdde1 
…o avoid unnecessarily executing subroutines that have already been subroutinized. It is necessary execute all subroutines when counting hints in order to determine the byte length of mask arguments, but we want to quit doing this when we know that counting hints is no longer necessary,. The previous logic stopped when a [vh]stem operator was seen, as this means there will not be need for hintmask mask arguments However, the [vh]stem operators can b
8000
e used even when there is a cntrmask, so the logic stopped counting hints too early.
@anthrotype
Copy link
Member

Thanks. Would be great if you could also add a test, maybe using the font that @khaledhosny uploaded to reproduce the issue in #1590

@khaledhosny khaledhosny merged commit 887ea22 into master May 2, 2019
@khaledhosny khaledhosny deleted the fix-subsetter-cff2-issue branch May 2, 2019 23:34
@anthrotype
Copy link
Member

Thanks

@readroberts
Copy link
Collaborator Author

I'll add a test when I am back work on Tues.

@anthrotype
Copy link
Member

Khaled already added one b1999a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueshade7 blueshade7 blueshade7 approved these changes

@behdad behdad Awaiting requested review from behdad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@readroberts @anthrotype @blueshade7 @khaledhosny
0