8000 [designspaceLib] use axis maps in DesignSpaceDocument.normalizeLocation by anthrotype · Pull Request #1521 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[designspaceLib] use axis maps in DesignSpaceDocument.normalizeLocation #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2019
Merged

[designspaceLib] use axis maps in DesignSpaceDocument.normalizeLocation #1521

merged 3 commits into from
Feb 27, 2019

Conversation

anthrotype
Copy link
Member

Fixes #1226

@anthrotype
varLib.plot: fix IndexError when specifying anonymous locations on th…
cbb7528 
…e commandline

Don't write title with the source's name where we don't have one
LettError
LettError approved these changes Feb 27, 2019
View reviewed changes
Copy link
Collaborator
@LettError LettError left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@LettError
Copy link
Collaborator

Something is failing though.

@anthrotype
Copy link
Member Author

importing fontTools.varLib.models at the top of designspaceLib/__init__.py leads to a circular import, I'll move the import statement inside the method that uses it.

@anthrotype anthrotype force-pushed the ds-normalize-location branch from c2af49b to 0475246 Compare February 27, 2019 23:17
@anthrotype anthrotype merged commit caa58d8 into fonttools:master Feb 27, 2019
@anthrotype anthrotype deleted the ds-normalize-location branch February 27, 2019 23:25
@anthrotype
Copy link
Member Author

After this PR, the fonttools varLib.plot script should now work as intented, with either a .designspace file as input, or with a list of locations, e.g.:

$ fonttools varLib.plot NotoSans-MM.designspace
$ fonttools varLib.plot -1,0 0,0 1,0 0,-1 0,1 0.5,0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behdad behdad behdad approved these changes

@LettError LettError LettError approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthrotype @LettError @behdad
0