[svgLib] add rudimentary support for shapes #1500
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
reviewed
Feb 13, 2019
| def _prefer_non_zero(*args): | ||
| for arg in args: | ||
| if arg != 0: | ||
| return arg |
There was a problem hiding this comment.
indentation should use four spaces like in the rest of the module
anthrotype
reviewed
Feb 13, 2019
| return 0. | ||
|
|
||
| def _ntos(n): | ||
| # %f likes to add unnecessary 0's, %g isn't consistent about # decimals |
anthrotype
approved these changes
Feb 13, 2019
anthrotype
added a commit
that referenced
this pull request
Feb 14, 2019
|
closing this, we'll continue on #1508 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to import SVGs with simple uses of
<rect>,<circle>,<polygon>by converting them to<path>