8000 Add context manager to XMLWriter by miguelsousa · Pull Request #1290 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add context manager to XMLWriter #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2018
Merged

Add context manager to XMLWriter #1290

merged 1 commit into from
Jul 9, 2018

Conversation

miguelsousa
Copy link
Collaborator

miguelsousa referenced 8DBD this pull request in adobe-type-tools/psautohint Jul 9, 2018
@khaledhosny
Drop micro optimization
93103c0 
That was never profiled and only meant to make me look smart. We need to
close the writer, though, otherwise data written to file will be
truncated.
@miguelsousa miguelsousa requested a review from anthrotype July 9, 2018 05:15
@anthrotype anthrotype merged commit 87178f4 into master Jul 9, 2018
@anthrotype anthrotype deleted the xmlwriter-context-manager branch July 9, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype Awaiting requested review from anthrotype

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelsousa @anthrotype
0