8000 [feaLib] asFea() shouldn’t fail when `subtable` is used by moyogo · Pull Request #1275 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[feaLib] asFea() shouldn’t fail when subtable is used #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2018
Merged

[feaLib] asFea() shouldn’t fail when subtable is used #1275

merged 2 commits into from
Jun 18, 2018

Conversation

moyogo
Copy link
Collaborator
@moyogo moyogo commented Jun 18, 2018

No description provided.

anthrotype
anthrotype approved these changes Jun 18, 2018
View reviewed changes
Copy link
Member
@anthrotype anthrotype left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for spotting this. Calling SubtableStatement.asFea() would raise NotImplementedError, whereas now it roundtrips from string to AST back to string correctly.

@anthrotype anthrotype merged commit e94cd9f into fonttools:master Jun 18, 2018
@moyogo moyogo deleted the feaLib-subtable branch June 18, 2018 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moyogo @anthrotype
0