[ttFont] fixes xmlWriter import error in _saveXML method with ttx split tables request #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it tables requests
|
wow.. did I release this? 💩 🤦♂️ |
|
Not sure how often split tables are used. It doesn't look like it was part of the test suite and it works when you don't split tables. |
|
Thank you Chris. I'll release a bugfix release very soon. |
|
Had a tough time figuring out the tests (i.e., I didn't spend enough time) or I would have simply contributed a test along with it... |
|
The tests covering ttx are in ttx_test.py. I'll try to add one for this. |
|
Thanks Miguel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue report: #1188
Closes #1188
Recognized in fontTools version 3.22.0 (PyPI release) with Python 3.6.4 interpreter
Problem: Attempt to dump split OT tables with ttx leads to NameError. This PR moves the xmlWriter import from within the public
saveXMLmethod to the top of the ttFont module.Replicated and confirmed test failure with this test:
https://github.com/chrissimpkins/fonttools/blob/88b0446d066ee72ad70eb41b382d184875c2fcbd/Tests/xmlwriter_test.py#L1-L14
and left this in a separate branch because I don't know how you are testing your ttx dumps to contribute it here. Can confirm that it fails before this change and does not fail after the change.