[morx] Implement morx ligatures subtable #1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only handling those parts that are shared with other substitution types. The actualy ligature actions are not implemented yet.
The hexdump in the specification is wrong, but the correct value is in the comments. Before this change, the finite-state transducer in our test data could be decompiled but would not implement the behavior explained in the AAT specification.
Tests fail because other subtables still need to be implemented.
Since the AAT ligature subtable does not encode the number of ligature glyphs, we need to infer this from the total structure length. We pass this around by creating a custom sub-reader that only has the substruct as its data. There might have been easier ways to accomplish this, but we should anyway change the XML output for MorxSubtables to use custom flag names, similar to what we're already doing for flags of morph actions. Having a custom converter for MorxSubtables is in preparation for that later XML format change.
|
This is great, thanks Sascha! |
|
It’s certainly an improvement over the current state. At some point I’d like to clean up the entire AAT handling (as you’ll see, it’s quite messy), but that can be done later. Merged this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the AAT ligatures subtable (type 2). There is still one last subtable of
morxthat remain to be implemented afterwards. But the themorx-ligaturesbranch can probably be merged.#1055