8000 [varLib] Initialize the avar segment map with required default entries by jenskutilek · Pull Request #1014 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[varLib] Initialize the avar segment map with required default entries #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2017
Merged

[varLib] Initialize the avar segment map with required default entries #1014

merged 3 commits into from
Jul 28, 2017

Conversation

jenskutilek
Copy link
Collaborator

All that remains of PR #1012

@jenskutilek jenskutilek requested a review from behdad July 24, 2017 08:55
This was referenced Jul 24, 2017
Closed
Closed
@jenskutilek jenskutilek changed the title Initialize the avar segment map with required default entries [varLib] Initialize the avar segment map with required default entries Jul 24, 2017
@anthrotype
Copy link
Member

mind also adding a test?

@anthrotype
Copy link
Member

In Tests/varLib/varLib_test.py we don't have a test with a designspace containing axis map elements, so that branch is not covered.
https://codecov.io/gh/fonttools/fonttools/src/2a67bddaeb59cab6d0ca48c88030a84759b2fdcc/Lib/fontTools/varLib/__init__.py#L94...120

@jenskutilek
Copy link
Collaborator Author

Would it be preferable to add completely new test data for this, or to integrate into one of the existing data files?

@anthrotype
Copy link
Member

New specific data would be preferable

@anthrotype
Copy link
Member
anthrotype commented Jul 25, 2017 •
edited
Loading

I mean, you can reuse the test master fonts, but a new designspace with axes map elements would be nice.

@behdad behdad merged commit 1136afd into master Jul 28, 2017
@anthrotype anthrotype deleted the varlib-avar-defaultmapping branch August 2, 2017 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behdad behdad Awaiting requested review from behdad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenskutilek @anthrotype @behdad
0