8000 [Designspace v5] getStatNames should probably consider instance attributes at the given location for computing names · Issue #2890 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Designspace v5] getStatNames should probably consider instance attributes at the given location for computing names #2890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
madig opened this issue Nov 11, 2022 · 1 comment · Fixed by #2892
Closed

[Designspace v5] getStatNames should probably consider instance attributes at the given location for computing names #2890

madig opened this issue Nov 11, 2022 · 1 comment · Fixed by #2892

Comments

@madig
Copy link
Collaborator
madig commented Nov 11, 2022

I think currently, only labels are considered. I.e. if I get the STAT names for a location with an instance, the PostScript name should probably reflect the instance's family and style name. Or maybe not?
@belluzj
Copy link
Contributor
belluzj commented Nov 14, 2022

The spirit of the getStatNames is the other way round: use the STAT data to compute default values for the instance family name, style name, stylemap names, and postscript name. If any of these computed names doesn't work for a particular instance, then it's up to the user to override the computed values with explicit attributes on the instance element. Otherwise, instance elements may have only a location, and all the names are optional.

The DS specification should be updated to reflect that.

madig added a commit that referenced this issue Nov 16, 2022
@madig
Clarify user expectations for getStatNames
7c83736 
Closes #2890
@madig madig mentioned this issue Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify user expectations for getStatNames fonttools/fonttools
2 participants
@madig @belluzj
0