8000 [varLib] Shifting composite glyphs in macOS · Issue #1381 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[varLib] Shifting composite glyphs in macOS #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jenskutilek opened this issue Nov 15, 2018 · 4 comments
Closed

[varLib] Shifting composite glyphs in macOS #1381

jenskutilek opened this issue Nov 15, 2018 · 4 comments

Comments

@jenskutilek
Copy link
Collaborator

googlefonts/fontmake#481

I had noticed this macOS rendering behaviour a long time ago, but the fix occurred to me only today. varLib could work around it by adding dummy entries to glyphs without necessary deltas to make sure they get an entry in the gvar table.

You can see it very clearly in Normschrift e.g. in ö (composites at default positions, no gvar entry), but not in Ö (dieresis is y-shifted so there is a gvar entry).
@behdad
Copy link
Member
behdad commented Nov 15, 2018

Right. I saw the same when I read your comment in other issue. It's slightly trickier than I like it to be, as the empty entries are optimized out during the compile process, so varLib needs a way to communicate it to the compiler that we want to retain empty entries for those glyphs..

@behdad
Copy link
Member
behdad commented Nov 15, 2018

Humm, or maybe not.

behdad added a 8000 commit that referenced this issue Nov 15, 2018
@behdad
[varLib] Always write tuple entries for composite glyphs
4c692b5 
Fixes #1381
Fixes googlefonts/fontmake#481
@behdad behdad mentioned this issue Nov 15, 2018
Merged
behdad added a commit that referenced this issue Nov 15, 2018
@behdad
[varLib] Always write tuple entries for composite glyphs
d84515d 
Fixes #1381
Fixes googlefonts/fontmake#481
jenskutilek pushed a commit that referenced this issue Dec 17, 2018
@behdad @jenskutilek
[varLib] Always write tuple entries for composite glyphs (#1383)
9c3dde3 
* [varLib] Always write tuple entries for composite glyphs

Fixes #1381
Fixes googlefonts/fontmake#481 partially

* Make sure at least one gvar delta is written for composites

* Add test data for composite fix

* Put in the correct issue link

* Typo

* Fix typos

* Expand comment, add link to issue

* Add ttx files for test font
jenskutilek added a commit that referenced this issue Dec 19, 2019
@jenskutilek
Remove workaround (#1381)
21af0be
@jenskutilek jenskutilek mentioned this issue Dec 19, 2019
Merged
@Lorp
Copy link
Lorp commented Aug 16, 2022

This bug in macOS 12.4 seems to apply to fonts that have the workaround:

Variable fonts rendering bug: composite glyphs disappear when all deltas are zero

@anthrotype
Copy link
Member

I get "Feedback not found". @Lorp can you copy/paste the content of the bug report here?

apply to fonts that have the workaround:

so IIUC, removing the workaround fixes the bug on macOS 12.4?

@anthrotype anthrotype mentioned this issue Sep 22, 2022
Closed
@cmyr cmyr mentioned this issue Sep 28, 2023
Merged
anthrotype pushed a commit that referenced this issue Feb 3, 2025
@jenskutilek @anthrotype
Remove workaround (#1381)
7f8f711
anthrotype added a commit that referenced this issue Feb 3, 2025
@anthrotype
Merge pull request #1788 from fonttools/remove-gvar-zero-workaround
696719b 
Remove workaround (#1381)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@behdad @Lorp @jenskutilek @anthrotype
0