8000
Provide struct bpf_timer forward declaration along with vmlinux.h by rhdxmr · Pull Request #223 · foniod/redbpf · GitHub
More Web Proxy on the site http://driver.im/
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jul 11, 2023. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Just out of interest, do you think we have coverage for actually testing this code in the current matrix? I just want to avoid a situation where this accidentally breaks something while fixing it for the newer kernels.
@rsdy
I think I don't comprehend what you asked to me because of lack of my English skills.
This change only affect the procedure that makes use of vmlinux.
I tested the modified code with kernel 5.15 that started to include struct bpf_timer in the vmlinux for the first time. I also tested it with kernel 5.13 that does not have struct bpf_timer in the vmlinux. And the ubuntu-2104-build-test tests generating rust bindings with vmlinux of the Linux kernel v5.11.
This PR just moves struct bpf_timer; from vmlinux_supplement.h to right after the vmlinux.h. It is just a forward declaration and there is no problem even if there exists real definition of struct bpf_timer in the vmlinux.h.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve the problem of
struct bpf_timer redefinitionreported by issue #218