fix(lsp): trigger signature help on retrigger chars #1066
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en.trigger is set
|
This PR is stale because it has been open 30 days with no activity. |
|
This is still relevant to ZLS. See here. |
|
This PR is stale because it has been open 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most LSPs will include retrigger chars (like
,) in the trigger chars list, but some likezlsfor Zig only have(for trigger chars. This fix adds retrigger chars to the list of signature auto-open characters.Note: It does not de-duplicate the array, but this should have negligible performance impact and cleaner code.
Related Issue(s)
None
Screenshots
None