UIEH-1397: The list of packages is no longer cut off in the modal window. #1697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
BogdanDenis
requested changes
Nov 3, 2023
| <Field | ||
| name="packageId" | ||
| component={Selection} | ||
| popper={{ | ||
| portal: document.getElementById('ModuleContainer'), |
There was a problem hiding this comment.
I think the root cause was the overflow on the modal, and the fix works when portal renders to OverlayContainer. So I'd prefer to use OverlayContainer because it's usually the element where we render such dropdowns
Good catch with the overflow!
There was a problem hiding this comment.
Scrolling doesn't work for me with OverlayContainer.
There was a problem hiding this comment.
Ok, let's keep ModuleContainer
BogdanDenis
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The list of packages is no longer cut off in the modal window.
Issues
UIEH-1397
Screencast
2023-11-03_13h23_44.mp4
Approach
TODOS and Open Questions
Learning
Screenshots