Improved README with clear instructions for local inference #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… change inference.py to save output in WAV format for better compatibility
|
I'm wondering whether we can just make the pyproject / uv script sort this automatically during the install . |
|
Yeah I think if you can change this to be specific for windows as I've tested in a few places on linux ubuntu and uv pip instal -e . works a without all these other steps. |
|
Should I close the pull request? |
|
No I want to merge this but I think have windows specific installation steps below linux specific setup steps. |
|
Alright. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.wavfile instead of.opus, making playback straightforward on any system.Details