8000 Add a short page for Android view integration by xster · Pull Request #5243 · flutter/website · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add a short page for Android view integration #5243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2021
Merged

Add a short page for Android view integration #5243

merged 1 commit into from
Feb 5, 2021

Conversation

xster
Copy link
Member
@xster xster commented Feb 1, 2021

Improves on #7785

@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Feb 1, 2021
@xster xster requested review from gaaclarke and sfshaza2 February 1, 2021 19:30
@xster xster mentioned this pull request Feb 1, 2021
Closed
gaaclarke
gaaclarke approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member
@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@xster
Copy link
Member Author
xster commented Feb 3, 2021

@sfshaza2 do you know what's up with the CI check? Seems like some version tangling on head?

@xster
Copy link
Member Author
xster commented Feb 5, 2021

Seems like there were a lot of errors but none are related to my changes. I'll try rebase again.

@xster
Copy link
Member Author
xster commented Feb 5, 2021

@sfshaza2 seems like master's breaking on head since yesterday

Screen Shot 2021-02-05 at 8 45 45 AM

@sfshaza2
Copy link
Contributor
sfshaza2 commented Feb 5, 2021 via email

@xster
Copy link
Member Author
xster commented Feb 5, 2021

Thanks @sfshaza2

@xster xster merged commit 878690c into flutter:master Feb 5, 2021
@xster xster deleted the android-view branch February 5, 2021 18:16
filiph pushed a commit to filiph/website that referenced this pull request Feb 22, 2021
@xster @filiph
Add a short page for Android view integration (flutter#5243)
676bc20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

@sfshaza2 sfshaza2 Awaiting requested review from sfshaza2

Assignees
No one assigned
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xster @sfshaza2 @gaaclarke
0