8000 [local_auth] Add native Android implementation of platform interface by BeMacized · Pull Request #4700 · flutter/plugins · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[local_auth] Add native Android implementation of platform interface #4700

Merged
merged 52 commits into from
Apr 11, 2022

Conversation

BeMacized
Copy link
Contributor
@BeMacized BeMacized commented Jan 26, 2022

This PR is one in a series to move the local_auth plugin to a federated architecture.

  1. Move local_auth into a subfolder and add a platform interface
    ([local_auth] Add platform interface to prepare for migration to federated architecture #4697)
  2. Add native implementations for the interface
  3. Refactor app facing plugin to make use of the platform interface and native implementations.
    ([local_auth] Refactor package to make use of new platform interface and native implementations #4701)

This PR remains in draft mode until #5195 has been merged.

Relevant issues:

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@BeMacized BeMacized force-pushed the local_auth/federation_android branch from 2ba8801 to cdf2cfe Compare January 27, 2022 11:33
@BeMacized BeMacized marked this pull request as draft April 8, 2022 08:50
@BeMacized BeMacized marked this pull request as ready for review April 11, 2022 18:21
Copy link
8000
Contributor
@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BeMacized BeMacized added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 11, 2022
@fluttergithubbot fluttergithubbot merged commit d05ec56 into flutter:main Apr 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p: local_auth platform-android waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0