8000 [google_maps_flutter_web] Migrate to null-safety. by ditman · Pull Request #3726 · flutter/plugins · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter_web] Migrate to null-safety. #3726

Merged
merged 30 commits into from
Mar 31, 2021
Merged

[google_maps_flutter_web] Migrate to null-safety. #3726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
2312a50
Update pubspec for null-safe versions.
ditman Mar 10, 2021
d70c136
First pass at null-safe gmaps
ditman Mar 11, 2021
4d17954
Fix _mapStyles in convert.dart. dartfmt -w .
ditman Mar 12, 2021
9bf65e2
Fix infoWindow content with the correct HtmlElement type.
ditman Mar 15, 2021
b192b45
Migrate marker_test.dart
ditman Mar 16, 2021
567afa2
Migrate shape_test.dart
ditman Mar 16, 2021
8928c23
Migrate markers_test.dart
ditman Mar 17, 2021
ab6653b
Migrate shapes_test.dart
ditman Mar 17, 2021
ee82b84
Bring back mockito for google_maps_plugin_test
ditman Mar 17, 2021
1d3435d
Migrate google_maps_plugin_test.dart
ditman Mar 17, 2021
d10806f
Tweak the widget getter so it can be made null when disposing.
ditman Mar 17, 2021
b0ff2f6
Add mocks, and the regen script
ditman Mar 17, 2021
d9885b2
Migrate google_maps_controller_test.dart
ditman Mar 17, 2021
77e9702
Call regen_mocks from run_test. Document Mocks.
ditman Mar 18, 2021
86f79ee
Add license to regen_mocks.sh
ditman Mar 18, 2021
2bd4073
Remove tests that don't apply in a post-null-safety world.
ditman Mar 18, 2021
a933c52
Cleanup lies from pubspec comments.
ditman Mar 18, 2021
dce7369
No need for left-hand-side type.
ditman Mar 18, 2021
f0abbf7
Make return type slightly more strict in _mapStyles convert function.
ditman Mar 18, 2021
b17d888
Prevent calling methods on Geometry controllers after calling remove.
ditman Mar 18, 2021
c33fc21
Some more PR reviews. dartfmt -w .
ditman Mar 19, 2021
5a08e9e
Remove unused _nullZoom
ditman Mar 19, 2021
fc41b15
Update to google_maps 5.1.0
ditman Mar 19, 2021
a6c2a7e
Add licenses.
ditman Mar 20, 2021< 8000 /relative-time>
151c74f
Single hash for license header in bash scripts.
ditman Mar 20, 2021
a991500
Make build work in stable, and build+test in master.
ditman Mar 22, 2021
65b6df0
Address PR comments (needs tests)
ditman Mar 30, 2021
870e759
Test latest assertions after disposal of maps controller.
ditman Mar 30, 2021
52f6dbd
dartfmt -w .
ditman Mar 30, 2021
0f701b1
Revert no-sound-null-safety in build_all_plugins_app
ditman Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/google_maps_flutter/google_maps_flutter_web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
## 0.3.0

* Migrate package to null-safety.
* **Breaking changes:**
* The property `icon` of a `Marker` cannot be `null`. Defaults to `BitmapDescriptor.defaultMarker`
* The property `initialCameraPosition` of a `GoogleMapController` can't be `null`. It is also marked as `required`.
* The parameter `creationId` of the `buildView` method cannot be `null` (this should be handled internally for users of the plugin)
* Most of the Controller methods can't be called after `remove`/`dispose`. Calling these methods now will throw an Assertion error. Before it'd be a no-op, or a null-pointer exception.

## 0.2.1

* Move integration tests to `example`.
Expand Down
10 changes: 10 additions & 0 deletions packages/google_maps_flutter/google_maps_flutter_web/example/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,13 @@ Make sure you have updated to the latest Flutter master.

* Single: `./run_test.sh integration_test/TEST_NAME.dart`
* All: `./run_test.sh`

## Mocks

There's new `.mocks.dart` files next to the test files that use them.

Mock files are [generated by `package:mockito`](https://github.com/dart-lang/mockito/blob/master/NULL_SAFETY_README.md#code-generation). The contents of these files can change with how the mocks are used within the tests, in addition to actual changes in the APIs they're mocking.

Mock files can be updated either manually by running the following command: `flutter pub run build_runner build` (or the `regen_mocks.sh` script), or automatically on each call to the `run_test.sh` script.

Please, add whatever changes show up in mock files to your PRs, or CI will fail.
6 changes: 6 additions & 0 deletions packages/google_maps_flutter/google_maps_flutter_web/example/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
targets:
$default:
sources:
- integration_test/*.dart
- lib/$lib$
- $package$
Loading
0