8000 [pigeon] moved command line logic from bin/ to lib/ by gaaclarke · Pull Request #313 · flutter/packages · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[pigeon] moved command line logic from bin/ to lib/ #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into flutter:master from
Mar 19, 2021
Merged

[pigeon] moved command line logic from bin/ to lib/ #313

merged 2 commits into from
Mar 19, 2021

Conversation

gaaclarke
Copy link
Member
@gaaclarke gaaclarke commented Mar 17, 2021 •
edited
Loading

This helps users wrap the command-line tools logic with their own logic. I also added an ignore for omit_local_variable_types since different people's linter settings might not agree on it (Flutter wants them, Dart doesn't).

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke changed the title [pigeon] moved the logic from bin to lib to help others wrap the [pigeon] moved command line logic from bin/ to lib/ Mar 18, 2021
@gaaclarke
[pigeon] moved the logic from bin to lib to help others wrap the
9b2ea4a 
command-line tools logic with their own logic.
@gaaclarke gaaclarke marked this pull request as ready for review March 18, 2021 18:25
@gaaclarke gaaclarke requested a review from xster March 18, 2021 18:43
@gaaclarke gaaclarke merged commit 3337df6 into flutter:master Mar 19, 2021
stuartmorgan-g pushed a commit to stuartmorgan-g/packages that referenced this pull request Apr 30, 2021
@creativecreatorormaybenot
Add option to fix intrinsic height measurement problems (flutter#313)
f5226f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xster xster xster approved these changes

@ajmalk ajmalk ajmalk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaaclarke @xster @ajmalk
0