8000 [pointer_interceptor] Migrate to null safety by mzdm · Pull Request #286 · flutter/packages · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[pointer_interceptor] Migrate to null safety #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 18, 2021
Merged

[pointer_interceptor] Migrate to null safety #286

merged 9 commits into from
Feb 18, 2021

Conversation

mzdm
Copy link
Contributor
@mzdm mzdm commented Feb 13, 2021

Related tracking issue flutter/flutter#75567

also:

  • Added package links to package list to main README.md
  • Added --web-renderer=html to integration test command
    (seems to be failing without that)
  • Not sure what to return in case of Shim methods
    (methods from engine are non-nullable so I replaced null with an empty string)

stuartmorgan-g
stuartmorgan-g requested changes Feb 16, 2021
View reviewed changes
@stuartmorgan-g
Copy link
Contributor

@ditman should do the full review here.

@ditman
Copy link
Member
ditman commented Feb 17, 2021

Thanks for the ping! This is my next task, I'll take a look within ~24h :)

ditman
ditman approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member
@ditman ditman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. I left some minor comments on the PR, and reversioned to 0.9.0. I've also migrated the integration_test code to null-safety!

Let's wait until #289 lands to merge this!

@google-cla

This comment has been minimized.

Sign in to view
@ditman

This comment has been minimized.

Sign in to view
@ditman
Copy link
Member
ditman commented Feb 18, 2021

(The publishable check will fail until #289 lands, and this branch is rebased)

@mzdm
Copy link
Contributor Author
mzdm commented Feb 18, 2021 •
edited
Loading

(The publishable check will fail until #289 lands, and this branch is rebased)

Alright, thank you for checking this and making the other changes!

@stuartmorgan-g
Copy link
Contributor

289 has landed, so you can merge in master and the test will pass.

@ditman ditman merged commit f17b20a into flutter:master Feb 18, 2021
@ditman
Copy link
Member
ditman commented Feb 18, 2021

Merged and published https://pub.dev/packages/pointer_interceptor/versions/0.9.0

It's still being listed as "Preview", I guess because of the version of the SDK we used being a "-0". We might have to revisit this to move 0.9.0 to stable.

@stuartmorgan-g
Copy link
Contributor

Preview is different than Pre-release; it just means that Pub has noticed that it depends on a version of the Dart SDK that's not yet released to stable (in this case, 2.12). It should automatically change to being listed as stable once that happens (per the very end of this recent post).

@ditman
Copy link
Member
ditman commented Feb 18, 2021

Ooooh, cool, I missed that memo! I thought the publishing warning of "you're publishing a not-preview version that depends on a preview version of the SDK" had toggled something when I published. Thanks for the link!

@mzdm mzdm deleted the nnbd-pointer-interceptor branch February 18, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g requested changes

@ditman ditman ditman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
< 362C a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/mzdm/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mzdm"> @mzdm @stuartmorgan-g @ditman
0