8000 [go_router] Fixes namedLocation to return URIs without trailing quest… by chunhtai · Pull Request #2471 · flutter/packages · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[go_router] Fixes namedLocation to return URIs without trailing quest… #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2022
Merged

[go_router] Fixes namedLocation to return URIs without trailing quest… #2471

merged 1 commit into from
Aug 18, 2022

Conversation

chunhtai
Copy link
Contributor

…ion marks if there are no query parameters.

fixes flutter/flutter#106605

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai chunhtai marked this pull request as ready for review August 18, 2022 16:49
@chunhtai chunhtai requested a review from johnpryan August 18, 2022 16:50
@johnpryan johnpryan merged commit 8ac5729 into flutter:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnpryan johnpryan johnpryan approved these changes

Assignees
No one assigned
Labels
p: go_router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go_router namedLocation() does not function as shown in documentation
2 participants
@chunhtai @johnpryan
0