8000 Revert "Automatic focus highlight mode for FocusManager (#37825)" by gspencergoog · Pull Request #38866 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "Automatic focus highlight mode for FocusManager (#37825)" #38866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2019
Merged

Revert "Automatic focus highlight mode for FocusManager (#37825)" #38866

merged 1 commit into from
Aug 21, 2019

Conversation

gspencergoog
Copy link
Contributor

This reverts commit a11d731 because of a regression in
flutter_gallery_ios32__transition_perf and 90th_percentile_frame_build_time_millis.

See issue #38860.

@gspencergoog
Revert "Automatic focus highlight mode for FocusManager (flutter#37825)"
d80b58e 
This reverts commit a11d731 because of a regression in
flutter_gallery_ios32__transition_perf and 90th_percentile_frame_build_time_millis.

See issue flutter#38860.
@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 20, 2019
cbracken
cbracken approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member
@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog
Copy link
Contributor Author

Note that reverting this is likely to cause a 3-5% increase in hello_world size, and a 15% regression in velocity_tracker_bench_aot_frontend (Moto G4).

@gspencergoog
Copy link
Contributor Author

I'm still trying to determine which is worse: the regression in flutter_gallery_transition_perf that resulted from the change, or the 5% regression in hello world binary size that will result in reverting this. I'm hoping to find a fix for the transition perf.

@gspencergoog gspencergoog merged commit f515bf6 into flutter:master Aug 21, 2019
@gspencergoog gspencergoog mentioned this pull request Aug 30, 2019
Merged
9 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cbracken cbracken cbracken approved these changes

@tvolkert tvolkert tvolkert approved these changes

@liyuqian liyuqian liyuqian approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gspencergoog @cbracken @tvolkert @liyuqian @googlebot @fluttergithubbot
0