8000 Move collectCoverageData into CoverageCollector so it can be re-used. by garymm · Pull Request #19055 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move collectCoverageData into CoverageCollector so it can be re-used. #19055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2018
Merged

Move collectCoverageData into CoverageCollector so it can be re-used. #19055

merged 1 commit into from
Jul 9, 2018

Conversation

garymm
Copy link
Contributor
@garymm garymm commented Jul 3, 2018

This will let us re-use that code from fuchsia_tester.dart.
Tested by running the stocks example tests with coverage collection before and after.
.lcov files are identical.

@garymm
Copy link
Contributor Author
garymm commented Jul 3, 2018

@cbracken has context on this

@cbracken
Copy link
Member
cbracken commented Jul 9, 2018

Thanks!

lgtm

@cbracken cbracken merged commit 66091f9 into flutter:master Jul 9, 2018
@garymm garymm deleted the test-coverage-refactor-0 branch July 9, 2018 20:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cbracken cbracken cbracken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garymm @cbracken @googlebot
0