[fuchsia] Fixes for Fuchsia hot reload #16317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrike69
reviewed
Apr 6, 2018
| @@ -421,10 +431,14 @@ class _PortForwarder { | |||
| return new _PortForwarder._(null, 0, 0, null, null); | |||
| } | |||
| final List<String> command = <String>[ | |||
| 'ssh', '-F', sshConfig, '-nNT', | |||
| 'ssh', '-F', sshConfig, '-nNT', '-vvv', | |||
There was a problem hiding this comment.
Did you mean to invoke ssh with -vvv here and below, or is this just left over from testing?
There was a problem hiding this comment.
Yes. I left them in intentionally. There is only a little extra output per tunnel, and it will only be seen when passing -v to the flutter tool.
rmacnak-google
approved these changes
Apr 6, 2018
| final List<_PortForwarder> forwarders = <_PortForwarder>[]; | ||
| for (int port in remotePorts) { | ||
| final _PortForwarder f = | ||
| await _PortForwarder.start(config, _address, port); |
There was a problem hiding this comment.
Consider accumulating futures and using Future.wait for the result so the tunnels can start in parallel.
There was a problem hiding this comment.
Leaving a good spot to await a Future.delayed() to make it easier to hack around FL-39.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes will be needed after FL-39 is resolved