8000 [flutter_plugin_tools] Make mobile platform flags required for the drive-examples command · Issue #58285 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[flutter_plugin_tools] Make mobile platform flags required for the drive-examples command #582 8000 85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cyanglaz opened this issue May 30, 2020 · 1 comment · Fixed by flutter/plugins#3490
Closed

[flutter_plugin_tools] Make mobile platform flags required for the drive-examples command #58285

cyanglaz opened this issue May 30, 2020 · 1 comment · Fixed by flutter/plugins#3490
Labels
p: tooling Affects the flutter_plugin_tools package package flutter/packages repository. See also p: labels.

Comments

@cyanglaz
Copy link
Contributor
cyanglaz commented May 30, 2020 •
edited
Loading

The current drive-examples command always runs for mobile. We had to add some workaround to make it ignore plugins that doesn't support mobile. See https://github.com/flutter/plugin_tools/pull/102
A better way to do this is to make mobile platform flags also required, just like all the other platforms. Then we can have the same logic for all the platforms.
This is a breaking change. The purpose for this change is to enhance the code maintainability of the flutter_plugin_tool for long term benefits.

If we make this change, we will need to update the repos' CIs(flutter/plugins, firebase) that uses the plugin tool to specify platforms like:
drive-examples --ios
drive-examples --android
Since the android drive test is running on firebase test lab. We'd have to update the command firebase test lab as well.

#56953
@cyanglaz cyanglaz added p: tooling Affects the flutter_plugin_tools package plugin labels May 30, 2020
@stuartmorgan-g stuartmorgan-g mentioned this issue Feb 16, 2021
Merged
@github-actions
Copy link
github-actions bot commented Aug 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
p: tooling Affects the flutter_plugin_tools package package flutter/packages repository. See also p: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove iOS stubs stuartmorgan-g/plugins
1 participant
@cyanglaz
0