8000 plugin_tools expects iOS and Android in example · Issue #56953 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

plugin_tools expects iOS and Android in example #56953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stuartmorgan-g opened this issue May 11, 2020 · 4 comments
Closed

plugin_tools expects iOS and Android in example #56953

stuartmorgan-g opened this issue May 11, 2020 · 4 comments
Assignees
@cyanglaz
Labels
p: tooling Affects the flutter_plugin_tools package

Comments

@stuartmorgan-g
Copy link
Contributor

Currently plugin_tools tries to drive every example app unconditionally for iOS and Android. This means that a *_macos, *_linux, etc. federated plugin package needs to have example/ios/* and example/android/* even though it doesn't implement them, or tests will (pointlessly) fail. See flutter/plugins#2589 for an example.

We should make the tooling check the (local, not app-facing) plugin's supported platforms for mobile as we do for desktop. We'll need to either retool the is-platform-x-supported check to understand the legacy plugin: section in pubspec.yaml, or ensure that all plugins in flutter/plugins are using the new schema (the latter may already be done, I'm not sure offhand if it was done comprehensively).
@stuartmorgan-g stuartmorgan-g added the p: tooling Affects the flutter_plugin_tools package label May 11, 2020
@stuartmorgan-g
Copy link
Contributor Author

https://github.com/stuartmorgan/plugin_tools/pull/new/dont-require-ios-android-examples is the first half of a PR to fix it. It prevents building, but doesn't prevent driving, so won't work as-is. I haven't had time to dig into how to prevent the drive step from happening since the logic is less obvious there, so if someone is interested in taking on the second part they are welcome to take it over. (If not, I'm not sure when I'll be able to get back to this.)

@cyanglaz cyanglaz self-assigned this May 29, 2020
@cyanglaz
Copy link
Contributor

@stuartmorgan I'm planning to work on the drive part. The link points to a on merged PR, do you want to land your PR? Does it require something else to land first?

@cyanglaz cyanglaz mentioned this issue May 30, 2020
Closed
@cyanglaz
Copy link
Contributor
cyanglaz commented Jun 2, 2020

Fixes on the tools are landed in https://github.com/flutter/plugin_tools/pull/102. Closing the issue.

@cyanglaz cyanglaz closed this as completed Jun 2, 2020
@cyanglaz cyanglaz mentioned this issue Sep 14, 2020
Merged
13 tasks
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cyanglaz cyanglaz

Labels
p: tooling Affects the flutter_plugin_tools package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stuartmorgan-g @cyanglaz
0