8000 Mixing Chinese and English characters create double underline on Huawei phones · Issue #30041 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Mixing Chinese and English characters create double underline on Huawei phones #30041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mehmetf opened this issue Mar 27, 2019 · 2 comments
Closed

Mixing Chinese and English characters create double underline on Huawei phones #30041

mehmetf opened this issue Mar 27, 2019 · 2 comments
Assignees
@jason-simmons
Labels
a: typography Text rendering, possibly libtxt customer: google Various Google teams

Comments

@mehmetf
Copy link
Contributor
mehmetf commented Mar 27, 2019

To reproduce, render this on a Huawei phone:

       Text(
          '中文 Button tapped 0 times.',
          style: TextStyle(
            color: Colors.blue,
            fontWeight: FontWeight.bold,
            decoration: TextDecoration.underline,
          )

Observe:

image

Could it be the baseline for Chinese vs English is different and we are using both to draw the underline?

This is from a Google customer so they are on the latest Flutter/Engine framework.
@mehmetf mehmetf added severe: customer critical a: typography Text rendering, possibly libtxt customer: google Various Google teams labels Mar 27, 2019
@HansMuller
Copy link
Contributor

CC @GaryQian

jason-simmons added a commit to jason-simmons/flutter_engine that referenced this issue Mar 29, 2019
@jason-simmons
libtxt: track the start and end x positions of glyph blobs for more a…
3802f44 
…ccurate rendering of text decorations

Fixes flutter/flutter#30041
Fixes flutter/flutter#24337
@jason-simmons jason-simmons mentioned this issue Mar 29, 2019
Merged
jason-simmons added a commit to flutter/engine that referenced this issue Mar 29, 2019
@jason-simmons
libtxt: track the start and end x positions of glyph blobs for more a…
1339011 
…ccurate rendering of text decorations (#8368)

Fixes flutter/flutter#30041
Fixes flutter/flutter#24337
@jason-simmons jason-simmons mentioned this issue Mar 29, 2019
Closed
RBogie pushed a commit to RBogie/flutter-engine that referenced this issue Apr 8, 2019
@jason-simmons @RBogie
libtxt: track the start and end x positions of glyph blobs for more a…
036169d 
…ccurate rendering of text decorations (flutter#8368)

Fixes flutter/flutter#30041
Fixes flutter/flutter#24337
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jason-simmons jason-simmons

Labels
a: typography Text rendering, possibly libtxt customer: google Various Google teams
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HansMuller @mehmetf @jason-simmons
0