8000 [Example] Remove layer before adding layer if layer is added in place source example by Chaoba · Pull Request #766 · flutter-mapbox-gl/maps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Example] Remove layer before adding layer if layer is added in place source example #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2021
Merged

[Example] Remove layer before adding layer if layer is added in place source example #766

merged 2 commits into from
Nov 20, 2021

Conversation

Chaoba
Copy link
Collaborator
@Chaoba Chaoba commented Nov 16, 2021

This PR adds a variable layerAdded to record the current status of imageLayer and will remove it before adding it, so that show Layer and show layer below water act normally.
Also removes the redundant Row widget.

Before After
device-2021-11-16-144023.mp4
device-2021-11-16-143651.mp4

|

felix-ht
felix-ht reviewed Nov 16, 2021
View reviewed changes
@Chaoba Chaoba requested a review from felix-ht November 17, 2021 12:19
felix-ht
felix-ht approved these changes Nov 17, 2021
View reviewed changes
Copy link
Collaborator
@felix-ht felix-ht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felix-ht
Copy link
Collaborator

@tobrun do you have any idea why the build fails to get the token?

@tobrun
Copy link
Collaborator
tobrun commented Nov 18, 2021

@tobrun do you have any idea why the build fails to get the token?

probably because of moving the repo to the new organization..
Re-added them, even though they were still listed.
Let's try again

@tobrun
Copy link
Collaborator
tobrun commented Nov 20, 2021

@tobrun do you have any idea why the build fails to get the token?

After double checking this 8000 all, it seems to be related to not sharing env. secrets with forked pull requests (which isn't a configuration or smth like that..)

@felix-ht
Copy link
Collaborator

@tobrun GitHub actions are quite messy - so what's the policy we merge fork prs without the builds as long as the review approved it?

We could also run a post merge build so stuff would not break without someone noticing it.

@tobrun
Copy link
Collaborator
tobrun commented Nov 20, 2021

We could also run a post merge build so stuff would not break without someone noticing it.

Not ideal but for now that way of working is fine.

@tobrun tobrun merged commit f7e4612 into flutter-mapbox-gl:master Nov 20, 2021
@Chaoba Chaoba deleted the kl-place-source branch November 21, 2021 11:37
m0nac0 added a commit to maplibre/flutter-maplibre-gl that referenced this pull request May 15, 2022
@m0nac0
Cherry-pick upstream#766
82cc6a9 
[Example] Remove layer before adding layer if layer is added in place source example
flutter-mapbox-gl/maps#766

Co-Authored-By: Kevin Li <kevin.li@mapbox.com>
@m0nac0 m0nac0 mentioned this pull request May 15, 2022
Merged 7EC3
m0nac0 added a commit to maplibre/flutter-maplibre-gl that referenced this pull request May 15, 2022
@m0nac0
Cherry-pick upstream#766 (#77)
04d4555 
[Example] Remove layer before adding layer if layer is added in place source example
flutter-mapbox-gl/maps#766

Co-authored-by: Kevin Li <kevin.li@mapbox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felix-ht felix-ht felix-ht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chaoba @felix-ht @tobrun
0