8000 Fix fix for empty FLOW_CONTEXT in Local Beach by kdambekalns · Pull Request #26 · flownative/docker-beach-php · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix fix for empty FLOW_CONTEXT in Local Beach #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

Fix fix for empty FLOW_CONTEXT in Local Beach #26

merged 1 commit into from
Feb 28, 2025

Conversation

kdambekalns
Copy link
Member

In (recent) Local Beach projects, FLOW_CONTEXT is set to an empty value if not given in the environment. This lead to FLOW_CONTEXT being empty, breaking configuration of Flow.

This fixes replacament of the check for being set with a check for not being empty to fix this by also checking for the variable to be set.

Otherwise it resulted in FLOW_CONTEXT: unbound variable during startup.

@kdambekalns
Fix fix for empty FLOW_CONTEXT in Local Beach
017eae6 
In (recent) Local Beach projects, `FLOW_CONTEXT` is set to an empty
value if not given in the environment. This lead to `FLOW_CONTEXT`
being empty, breaking configuration of Flow.

This fixes replacament of the check for being set with a check for
not being empty to fix this by also checking for the variable to be
set.

Otherwise it resulted in `FLOW_CONTEXT: unbound variable` during
startup.
@kdambekalns kdambekalns self-assigned this Feb 28, 2025
@kdambekalns
Copy link
Member Author

Lesson learned: You can never test too much… I checked that it works with the case that was broken ($FLOW_CONTEXT being set but empty), but I did not test it with the variable not being set at all. 🙈

This was referenced Feb 28, 2025
Merged
Merged
kitsunet
kitsunet approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member
@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kdambekalns
Copy link
Member Author

Then LGTM. 🤞

@kdambekalns kdambekalns merged commit 571a744 into main Feb 28, 2025
@kdambekalns kdambekalns deleted the bugfix/unbound-variable-use branch February 28, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsunet kitsunet kitsunet approved these changes

@robertlemke robertlemke Awaiting requested review from robertlemke

@markusguenther markusguenther Awaiting requested review from markusguenther

Assignees

@kdambekalns kdambekalns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdambekalns @kitsunet
0