Fix banner skip detection #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `FLOWNATIVE_LIB_PATH` is not set, the commands later in the script will fail – so this is not a case that will happen. OTOH skipping the banner unless in an interactive shell makes sense. Related to flownative/localbeach#82
kdambekalns
added a commit
to flownative/localbeach
that referenced
this pull request
Sep 20, 2024
This makes the shell spawned by `beach exec´ when used to directly run commands in the container a login shell. That makes it read the file `~/.profile` and thus sets environment variables as expected. With flownative/docker-beach-php#18 the banner will still be skipped. Fixes #82
kdambekalns
added a commit
to flownative/localbeach
that referenced
this pull request
Sep 20, 2024
This makes the shell spawned by `beach exec` when used to directly run commands in the container a login shell. That makes it read the file `~/.profile` and thus sets environment variables as expected. With flownative/docker-beach-php#18 the banner will still be skipped. Fixes #82
|
Ah, now I get it – if that variable is not set, sourcing |
kdambekalns
added a commit
that referenced
this pull request
Oct 7, 2024
This was broken with PR #18…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
FLOWNATIVE_LIB_PATHis not set, the commands later in the script will fail – so this is not a case that will happen.OTOH skipping the banner unless in an interactive shell makes sense.
Related to flownative/localbeach#82