8000 Export our JS using AMD-compatible modules (2) by almarklein · Pull Request #271 · flexxui/flexx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Export our JS using AMD-compatible modules (2) #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 65 commits into from
Nov 17, 2016
Merged

Export our JS using AMD-compatible modules (2) #271

merged 65 commits into from
Nov 17, 2016

Conversation

almarklein
Copy link
Member
@almarklein almarklein commented Nov 16, 2016 •
edited
Loading

This supersedes #225 (since that branch seemed broken).

This is related to #224 (fixes part of it). The description/discussion here focuses on the implementation in Flexx. Implements #231.

This PR turned rather epic. PR's merged into this: #254, #264, #266.

  • Improve reporting of PyScript transpilation errors.
  • Remove support for import syntax in PyScript.
  • PyScript has better (more explicit) support for modules (of different types).
  • Provide a mechanism to create JS assets as modules. Dependencies and exports can be defined on these module objects, and to some extend automatically detected.
  • Refactor asset manager to be aware (or not?) of modules.
  • Put JS loader logic in PyScript subpackage
  • Make sure that it works with requirejs (i.e. in the notebook)
  • Automate the dependency of PyScript std (and importing its names).
  • Make export work again; it breaks the docs.
  • Fix / add tests
  • Implement backward compatible create_module_assets() function for now.
  • Can get rid of flexx.classes prefix for Model classes.
  • Can get rid of mangling to make isinstance() (and super()?) work for Model classes.
  • Allow interactive mode (besides the notebook), so we can better test module loading.
  • Update docs on assets and data.
  • Update docs on PyScript modules.

Next

  • Load remote assets without deps at the end.
  • require using import? we now do this via imports in Python!
  • Improve Flexx loader so it can load modules out of order. (no rush, as we control the order that the assets are added to the page).
  • Make it work with webpack window.define() provided by Jupyterlab
  • PyScript std can probably reduce/remove prefixes, since they are not global anymore. Also look at reducing size of single-class modules (half of the code is stdlib imports :/ ).
  • Minification (light-weight) of the modules we produce
  • Maybe remove support for nodejs in flexx.app and flexx.webruntime; only targeting browsers simplifies things a lot. If not, make sure it works (again).
  • Do we want per-session assets or not?
  • Improve data handling (see Provide means to send large (binary) data between Python and JS #143)

@almarklein
PyScript: remove support for import syntax
281b28d
@almarklein
PyScript: better reporting of JSError (invalid PyScript)
a365db7
@almarklein
fix examples that used import
468dbbc
@almarklein
WIP refactoring asset store and session assets
9990099
@almarklein
Fix png module shape
8f76de8
@almarklein
remove session_id query string from url at JS init time
5eda2d4
@almarklein
Refactoring of tornadoserver and some renaming
7f931f4
@almarklein
Add example
65f903a
@almarklein
Use a single Asset class. simpliefies add_asset() and add_shared_asset()
44a0f52
@almarklein
Improve auto-dependency of pyscript-stdlib.js
7577db7
@almarklein
PyScript: create_js_module move/clean/test
6248ebf
@almarklein
License header + "use strict" handled in the right places
6ebab3a
@almarklein
PyScript docs
6d33bc2
@almarklein
Improve AMD loader and a bit of cleanup
a1d0f06
@almarklein
Make export work again. Plus several tweaks to remote assets.
db9be87
@almarklein
Make data work for exported apps
d3988c6
@almarklein
asset store tests
d1a1086
@almarklein
style fixes
4dd378b
@almarklein
post-rebase tweak
30c04dd
@almarklein
Simplify naming of Model classes in JS
55d07b6
@almarklein
Help users that used modules transition to new system
08e4d8b
@almarklein
Fixes for notebook (though notebook is still broken)
51b315a
@almarklein
Cleanup
13bceea
@almarklein
apparently this object literal notation does not work in older browsers
3ac04b7
@almarklein
suppress error in the right place
6e8c125
@almarklein
Improvements to (dynamic) asset loading
072304c
@almarklein
Interactive mode!
adcb1ad
@almarklein
Improve how we have a default active model.
f7be0d1
@almarklein
Update pyscript docs
9cdde45
@almarklein
Update app docs (mostly about assets/data)
29fec28
@almarklein almarklein changed the title Modules4 Export our JS using AMD-compatible modules (2) Nov 16, 2016
@almarklein almarklein added this to the v0.5 milestone Nov 16, 2016
@almarklein almarklein mentioned this pull request Nov 16, 2016
Closed
@almarklein
Copy link
Member Author

I think this is done for now. Hooray!

@Korijn
Copy link
Korijn commented Nov 17, 2016

Hooray indeed. :)

@almarklein almarklein merged commit 3f043b5 into master Nov 17, 2016
@almarklein almarklein deleted the modules4 branch November 17, 2016 12:51
This was referenced Nov 17, 2016
Closed
Open
Closed
Closed
Merged
@almarklein almarklein mentioned this pull request Dec 2, 2016
Merged
@almarklein almarklein modified the milestones: v0.5, v0.4.2 Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: ready tag: app type: task
Projects
None yet
Milestone
v0.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@almarklein @Korijn
0