8000 Resolve `Exception` short-circuits for normal execution flow internally by yvo-niedrich · Pull Request #861 · flat3/lodata · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Resolve Exception short-circuits for normal execution flow internally #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 5.x
Choose a base branch
from
Open

Resolve Exception short-circuits for normal execution flow internally #861

wants to merge 1 commit into from

Conversation

yvo-niedrich
Copy link
Contributor

Laravel converts the Exception into a proper HTTP response but tracing and observability tools will still report errors for uncaught exceptions.

  • Responses without content (202, 204, 302, 304) no longer return a content-type header
  • ProtocolExceptions for the above are no longer surfaced

@yvo-niedrich
Resolve Exception short-circuits for normal execution flow internally
8e61f60 
Laravel converts the Exception into a proper HTTP response but tracing and observability tools will still report errors for uncaught exceptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yvo-niedrich
0