8000 feat: Replace ColorPreviewInput preview box with 'color' input by dsevillamartin · Pull Request #3271 · flarum/framework · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Replace ColorPreviewInput preview box with 'color' input #3271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2022
Merged

feat: Replace ColorPreviewInput preview box with 'color' input #3271

merged 1 commit into from
Mar 10, 2022

Conversation

dsevillamartin
Copy link
Member

Changes proposed in this pull request:

  • Replace the preview box with a color input that allows for easier modification of colors while still having a text field
  • Extracts id from attrs so that it's not used for two inputs

Reviewers should focus on:

  • Do we want a check for whether color input is supported? It seems to have good support, but on iOS it is not supported in UIWebView (deprecated, removed in iOS 13 I believe)
  • Do we want to make this optional or just change the functionality to be usable? I don't see any reason for it to be an option, but we could do that.

Screenshot

(Ignore the 'Primary color' label)

firefox_CjkLwpfVAV.mp4
msedge_ABFBgEB8nD.mp4

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@askvortsov1 askvortsov1 force-pushed the ds/color-preview-input-use-color-input-type branch from 9e763c1 to 59dc3c2 Compare January 30, 2022 22:54
@askvortsov1
Copy link
Member

It's not working for me locally on Chrome
image

@dsevillamartin
Copy link
Member Author

@askvortsov1 That's odd. It works for me.

While developing this, I had a few issues when CSS sometimes didn't get properly recompiled and I had to manually clear the Flarum cache. Perhaps that is what is happening to you?

This is in Chrome (downloaded to make sure Chromium Edge was working and Chrome wasn't)

image

askvortsov1
askvortsov1 approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member
@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working now, LGMT!

@askvortsov1 askvortsov1 merged commit be1b571 into master Mar 10, 2022
@askvortsov1 askvortsov1 deleted the ds/color-preview-input-use-color-input-type branch March 10, 2022 00:56
@askvortsov1 askvortsov1 added this to the 1.3 milestone Mar 10, 2022
@SychO9 SychO9 changed the title Replace ColorPreviewInput preview box with 'color' input feat: Replace ColorPreviewInput preview box with 'color' input Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

@davwheat davwheat Awaiting requested review from davwheat

Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@dsevillamartin @askvortsov1 @SychO9
0