8000 A few minor fixes to review by flaix · Pull Request #9 · flaix/gitblit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

A few minor fixes to review #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

flaix
Copy link
Owner
@flaix flaix commented Nov 7, 2019

Buried within this merge request seemingly lie a few minor fixes worth checking out.

Copy link
Owner Author
@flaix flaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18dcf5e

I wonder what the use case for this is. I was unable to fabricate a Git setting, where a user.name would be only blanks caught by the isWhitespace method.

Copy link
Owner Author
@flaix flaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4865c5c

The first hunk looks wrong.

The second hunk was integrated.

Copy link
Owner Author
@flaix flaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

76066ae

Nice catch.
Integrated, but fixed differently, as there was a problem with the search for multiple locale strings and the same problem exists on the EditUserPage.

@flaix
Copy link
Owner Author
flaix commented Nov 11, 2019

The good parts integrated with 96a7e6e in gitblit-org#1324.

@flaix flaix closed this Nov 11, 2019
< 5CB7 /option>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0