Fix another edge case in _compute_drho #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, yes. We're getting there. In the test code that I produced in #189 (comment), the case that you have fixed would have resulted in an inconsistency for |
s-kuberski
approved these changes
Jun 2, 2023
fjosw
added a commit
that referenced
this pull request
Jun 2, 2023
* tests: failing test for compute_drho edge case added. * tests: example file for failing compute_drho added. * tests: assertion that dvalue stays the same added to compute drho test. * fix: another edge case in computation of drho fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of my analysis scripts failed after the recent changes in #172. I added a minimal failing example and fixed the problem with another small modification in
_compute_drho. All tests seem to be passing, please have a close look.